fixed memory issues

kgOrdersServer/Source/Lookup.ServiceImpl.pas

@@ -173,16 +173,11 @@ var
   SQL: string;
   rptOrders: TrptOrders; // Local instance of rptOrders
 begin
-  // Create instance of rptOrders
   rptOrders := TrptOrders.Create(nil);
   try
-    // Generate SQL dynamically using the existing GetOrders logic
     SQL := GenerateOrdersSQL(searchOptions).SQL;
-
-    // Prepare the report dataset
     result := rptOrders.PrepareReport(SQL);
 
-    // Generate the PDF report
     //rptOrders.GeneratePDF;
 
     // Optionally, log success
@@ -389,24 +384,34 @@ begin
   result.whereSQL := whereSQL;
 end;
 
-function TLookupService.getColorCount(colors: string): string;
+function TLookupService.GetColorCount(colors: string): string;
 var
   colorObject: TJSONObject;
   colorList: TJSONArray;
-  temp: string;
-  temp2: string;
 begin
   if colors = '' then
-    result := '0'
+    Result := '0'
   else
   begin
     colorObject := TJSONObject.ParseJSONValue(colors) as TJSONObject;
-    colorList := TJSONArray(colorObject.GetValue('items'));
-    //temp := colorList.toString;
-    result := IntToStr(colorList.Count);
+    try
+      if Assigned(colorObject) then
+      begin
+        colorList := colorObject.GetValue<TJSONArray>('items');
+        if Assigned(colorList) then
+          Result := IntToStr(colorList.Count)
+        else
+          Result := '0';
+      end
+      else
+        Result := '0';
+    finally
+      colorObject.Free;
+    end;
   end;
 end;
 
+
 function TLookupService.GetOrders(searchOptions: string): TOrderList;
 var
   SQL: string;
@@ -414,69 +419,76 @@ var
   Order: TOrderItem;
   colors: string;
   ColorType: string;
-  SQLArray: TArray<string>;
   SQLQuery: TSQLQuery;
 begin
   SQLQuery := generateOrdersSQL(searchOptions);
+  TXDataOperationContext.Current.Handler.ManagedObjects.Add(SQLQuery); // Added SQLQuery to ManagedObjects
+
+  Result := TOrderList.Create;
+  try
+    Result.data := TList<TOrderItem>.Create;
+    TXDataOperationContext.Current.Handler.ManagedObjects.Add(Result.data);
 
     SQL := SQLQuery.SQL;
     whereSQL := SQLQuery.whereSQL;
 
     doQuery(ordersDB.UniQuery1, SQL);
 
-  Result:= TOrderList.Create;
-  Result.data := TList<TOrderItem>.Create;
-  TXDataOperationContext.Current.Handler.ManagedObjects.Add( Result.data );
     while not ordersDB.UniQuery1.Eof do
     begin
       Order := TOrderItem.Create;
-    TXDataOperationContext.Current.Handler.ManagedObjects.Add( Order );
-    Result.data.Add( Order );
-    order.ID := ordersDB.UniQuery1.FieldByName('ORDER_ID').AsString;
-    order.companyName := ordersDB.UniQuery1.FieldByName('COMPANY_NAME').AsString;
-    order.jobName := ordersDB.UniQuery1.FieldByName('JOB_NAME').AsString;
-    order.orderDate := ordersDB.UniQuery1.FieldByName('ORDER_DATE').AsString;
-    order.proofDue := ordersDB.UniQuery1.FieldByName('PROOF_DUE').AsString;
-    order.proofDone := ordersDB.UniQuery1.FieldByName('PROOF_DONE').AsString;
-    order.artDue := ordersDB.UniQuery1.FieldByName('ART_DUE').AsString;
-    order.artDone := ordersDB.UniQuery1.FieldByName('ART_DONE').AsString;
-    order.plateDue := ordersDB.UniQuery1.FieldByName('PLATE_DUE').AsString;
-    order.plateDone := ordersDB.UniQuery1.FieldByName('PLATE_DONE').AsString;
-    order.mountDue := ordersDB.UniQuery1.FieldByName('MOUNT_DUE').AsString;
-    order.mountDone := ordersDB.UniQuery1.FieldByName('MOUNT_DONE').AsString;
-    order.shipDue := ordersDB.UniQuery1.FieldByName('SHIP_DUE').AsString;
-    order.shipDone := ordersDB.UniQuery1.FieldByName('SHIP_DONE').AsString;
-    order.price := ordersDB.UniQuery1.FieldByName('PRICE').AsString;
-    order.qbRefNum := ordersDB.UniQuery1.FieldByName('QB_REF_NUM').AsString;
-    order.orderType := ordersDB.UniQuery1.FieldByName('ORDER_TYPE').AsString.Replace('_', ' ');
+      TXDataOperationContext.Current.Handler.ManagedObjects.Add(Order);
+      Result.data.Add(Order);
+
+      Order.ID := ordersDB.UniQuery1.FieldByName('ORDER_ID').AsString;
+      Order.companyName := ordersDB.UniQuery1.FieldByName('COMPANY_NAME').AsString;
+      Order.jobName := ordersDB.UniQuery1.FieldByName('JOB_NAME').AsString;
+      Order.orderDate := ordersDB.UniQuery1.FieldByName('ORDER_DATE').AsString;
+      Order.proofDue := ordersDB.UniQuery1.FieldByName('PROOF_DUE').AsString;
+      Order.proofDone := ordersDB.UniQuery1.FieldByName('PROOF_DONE').AsString;
+      Order.artDue := ordersDB.UniQuery1.FieldByName('ART_DUE').AsString;
+      Order.artDone := ordersDB.UniQuery1.FieldByName('ART_DONE').AsString;
+      Order.plateDue := ordersDB.UniQuery1.FieldByName('PLATE_DUE').AsString;
+      Order.plateDone := ordersDB.UniQuery1.FieldByName('PLATE_DONE').AsString;
+      Order.mountDue := ordersDB.UniQuery1.FieldByName('MOUNT_DUE').AsString;
+      Order.mountDone := ordersDB.UniQuery1.FieldByName('MOUNT_DONE').AsString;
+      Order.shipDue := ordersDB.UniQuery1.FieldByName('SHIP_DUE').AsString;
+      Order.shipDone := ordersDB.UniQuery1.FieldByName('SHIP_DONE').AsString;
+      Order.price := ordersDB.UniQuery1.FieldByName('PRICE').AsString;
+      Order.qbRefNum := ordersDB.UniQuery1.FieldByName('QB_REF_NUM').AsString;
+      Order.orderType := ordersDB.UniQuery1.FieldByName('ORDER_TYPE').AsString.Replace('_', ' ');
 
       if ordersDB.UniQuery1.FieldByName('ORDER_TYPE').AsString = 'web_plate' then
       begin
-      colorType := 'quantity_and_colors_qty_colors';
-      SQL := 'Select quantity_and_colors_qty_colors from web_plate_orders where order_id = ' + order.ID;
+        ColorType := 'quantity_and_colors_qty_colors';
+        SQL := 'Select quantity_and_colors_qty_colors from web_plate_orders where order_id = ' + Order.ID;
       end
       else
       begin
-      colorType := 'colors_colors';
-      SQL := 'Select colors_colors from corrugated_plate_orders where order_id = ' + order.ID;
+        ColorType := 'colors_colors';
+        SQL := 'Select colors_colors from corrugated_plate_orders where order_id = ' + Order.ID;
       end;
 
       doQuery(ordersDB.UniQuery2, SQL);
       colors := ordersDB.UniQuery2.FieldByName(ColorType).AsString;
-    order.colors := getColorCount(colors);
+      Order.colors := GetColorCount(colors);
 
       ordersDB.UniQuery1.Next;
     end;
 
     ordersDB.UniQuery1.Close;
-  SQL := 'SELECT COUNT(*) AS total_count ' + whereSQL;
 
+    SQL := 'SELECT COUNT(*) AS total_count ' + whereSQL;
     doQuery(ordersDB.UniQuery1, SQL);
     Result.count := ordersDB.UniQuery1.FieldByName('total_count').AsInteger;
 
     ordersDB.UniQuery1.Close;
+  except
+    Result.Free; // Cleaned up memory in case of exceptions
+  end;
 end;
 
+
 function TLookupService.GetOrder(orderInfo: string): TFullOrder;
 var
   orderType: string;
@@ -832,23 +844,140 @@ begin
   ordersDB.UniQuery1.Close;
 end;
 
+// -- Keeping this here in case you need to revert to it for some reason.
+// -- The new version handles the memory issue on the exception.
+
+//function TLookupService.AddCorrugatedOrder(orderInfo: string): TJSONObject;
+//var
+//  JSONData, ResponseData: TJSONObject;
+//  SQL: string;
+//  Pair: TJSONPair;
+//  Field: TField;
+//  DateFormat: TFormatSettings;
+//  ORDER_ID: integer;
+//  mode: string;
+//begin
+//  DateFormat := TFormatSettings.Create;
+//  DateFormat.ShortDateFormat := 'yyyy-mm-dd';
+//  DateFormat.DateSeparator := '-';
+//  JSONData := TJSONObject.ParseJSONValue(orderInfo) as TJSONObject;
+//  if JSONData = nil then
+//    raise Exception.Create('Invalid JSON format');  // If parsing fails, raise an exception
+//  mode := JSONData.GetValue<string>('mode');
+//  if mode = 'ADD' then
+//    SQL := 'select * from corrugated_plate_orders where ORDER_ID = 0 and ORDER_ID <> 0'
+//  else
+//  begin
+//    ORDER_ID := JSONData.GetValue<integer>('ORDER_ID');
+//    SQL := 'select * from corrugated_plate_orders where ORDER_ID = ' + IntToStr(ORDER_ID);
+//  end;
+//  doQuery(ordersDB.UniQuery1, SQL);
+//  try
+//    if mode = 'ADD' then
+//      ordersDB.UniQuery1.Insert
+//    else
+//      ordersDB.UniQuery1.Edit;
+//
+//    for Pair in JSONData do
+//    begin
+//      Field := ordersDB.UniQuery1.FindField(Pair.JsonString.Value); // Checks if the field exists in the dataset
+//      if Assigned(Field) then
+//      begin
+//      // handles any dates or datetimes
+//        if (Field is TDateTimeField) and (Pair.JsonValue.Value <> '') then
+//          TDateTimeField(Field).AsDateTime := StrToDate(Pair.JsonValue.Value)
+//        else if Pair.JsonValue.Value <> '' then
+//          Field.AsString := Pair.JsonValue.Value;
+//      end;
+//    end;
+//
+//    // Post the record to the database
+//    ordersDB.UniQuery1.Post;
+//
+//    if mode = 'ADD' then
+//    begin
+//      SQL := 'select * from orders where ORDER_ID = 0 and ORDER_ID <> 0';
+//      doQuery(ordersDB.UniQuery1, SQL);
+//      ordersDB.UniQuery1.Insert;
+//    end
+//    else
+//    begin
+//      SQL := 'select * from orders where ORDER_ID = ' + IntToStr(ORDER_ID);
+//      doQuery(ordersDB.UniQuery1, SQL);
+//    end;
+//
+//    ordersDB.UniQuery1.FieldByName('COMPANY_ID').AsString := JSONData.GetValue<string>('COMPANY_ID');
+//    ordersDB.UniQuery1.FieldByName('ORDER_TYPE').AsString := 'corrugated_plate';
+//
+//    if mode = 'ADD' then
+//      ordersDB.UniQuery1.FieldByName('ORDER_DATE').AsDateTime := Now;
+//
+//    if JSONData.GetValue<string>('staff_fields_price') = '' then
+//      ordersDB.UniQuery1.FieldByName('PRICE').AsString := '0'
+//    else
+//      ordersDB.UniQuery1.FieldByName('PRICE').AsString := JSONData.GetValue<string>('staff_fields_price');
+//
+//    ordersDB.UniQuery1.FieldByName('JOB_NAME').AsString := JSONData.GetValue<string>('staff_fields_job_name');
+//    ordersDB.UniQuery1.FieldByName('USER_ID').AsString := JSONData.GetValue<string>('USER_ID');
+//    ordersDB.UniQuery1.FieldByName('LOCATION').AsString := JSONData.GetValue<string>('staff_fields_art_location');
+//
+//    ordersDB.UniQuery1.Post;
+//
+//    ordersDB.UniQuery1.Close;
+//    if mode = 'ADD' then
+//    begin
+//      ordersDB.UniQuery1.SQL.Text := 'SELECT LAST_INSERT_ID() AS OrderID'; // Use database's method to get the last inserted ID
+//      ordersDB.UniQuery1.Open;
+//      ORDER_ID := ordersDB.UniQuery1.FieldByName('OrderID').AsInteger;
+//    end;
+//
+//    if JSONData.GetValue<string>('staff_fields_proof_date') <> '' then
+//      AddStatusSchedule('PROOF', JSONData, ORDER_ID);
+//    if JSONData.GetValue<string>('staff_fields_ship_date') <> '' then
+//      AddStatusSchedule('SHIP', JSONData, ORDER_ID);
+//    if JSONData.GetValue<string>('staff_fields_art_due') <> '' then
+//      AddStatusSchedule('ART', JSONData, ORDER_ID);
+//    if JSONData.GetValue<string>('staff_fields_plate_due') <> '' then
+//      AddStatusSchedule('PLATE', JSONData, ORDER_ID);
+//    if JSONData.GetValue<string>('staff_fields_mount_due') <> '' then
+//      AddStatusSchedule('MOUNT', JSONData, ORDER_ID);
+//
+//    Result := TJSONObject.Create.AddPair('status', 'success');
+//    TXDataOperationContext.Current.Handler.ManagedObjects.Add(Result);
+//    except
+//    on E: Exception do
+//    begin
+//      Result := TJSONObject.Create.AddPair('error', E.Message);
+//    end;
+//  end;
+//end;
+
+
 function TLookupService.AddCorrugatedOrder(orderInfo: string): TJSONObject;
 var
-  JSONData, ResponseData: TJSONObject;
+  JSONData: TJSONObject;
   SQL: string;
   Pair: TJSONPair;
   Field: TField;
   DateFormat: TFormatSettings;
-  CurrDate: TDateTime;
   ORDER_ID: integer;
   mode: string;
 begin
   DateFormat := TFormatSettings.Create;
   DateFormat.ShortDateFormat := 'yyyy-mm-dd';
   DateFormat.DateSeparator := '-';
+
+  // Initialize Result object and add it to ManagedObjects upfront
+  Result := TJSONObject.Create;
+  TXDataOperationContext.Current.Handler.ManagedObjects.Add(Result);
+
   JSONData := TJSONObject.ParseJSONValue(orderInfo) as TJSONObject;
   if JSONData = nil then
-    raise Exception.Create('Invalid JSON format');  // If parsing fails, raise an exception
+  begin
+    Result.AddPair('error', 'Invalid JSON format'); // Populate error in Result
+    Exit;
+  end;
+
   mode := JSONData.GetValue<string>('mode');
   if mode = 'ADD' then
     SQL := 'select * from corrugated_plate_orders where ORDER_ID = 0 and ORDER_ID <> 0'
@@ -857,8 +986,10 @@ begin
     ORDER_ID := JSONData.GetValue<integer>('ORDER_ID');
     SQL := 'select * from corrugated_plate_orders where ORDER_ID = ' + IntToStr(ORDER_ID);
   end;
-  doQuery(ordersDB.UniQuery1, SQL);
+
   try
+    doQuery(ordersDB.UniQuery1, SQL);
+
     if mode = 'ADD' then
       ordersDB.UniQuery1.Insert
     else
@@ -866,18 +997,16 @@ begin
 
     for Pair in JSONData do
     begin
-      Field := ordersDB.UniQuery1.FindField(Pair.JsonString.Value); // Checks if the field exists in the dataset
+      Field := ordersDB.UniQuery1.FindField(Pair.JsonString.Value);
       if Assigned(Field) then
       begin
-      // handles any dates or datetimes
         if (Field is TDateTimeField) and (Pair.JsonValue.Value <> '') then
-          TDateTimeField(Field).AsDateTime := StrToDate(Pair.JsonValue.Value)
+          TDateTimeField(Field).AsDateTime := StrToDate(Pair.JsonValue.Value, DateFormat)
         else if Pair.JsonValue.Value <> '' then
           Field.AsString := Pair.JsonValue.Value;
       end;
     end;
 
-    // Post the record to the database
     ordersDB.UniQuery1.Post;
 
     if mode = 'ADD' then
@@ -910,6 +1039,7 @@ begin
     ordersDB.UniQuery1.Post;
 
     ordersDB.UniQuery1.Close;
+
     if mode = 'ADD' then
     begin
       ordersDB.UniQuery1.SQL.Text := 'SELECT LAST_INSERT_ID() AS OrderID'; // Use database's method to get the last inserted ID
@@ -928,16 +1058,17 @@ begin
     if JSONData.GetValue<string>('staff_fields_mount_due') <> '' then
       AddStatusSchedule('MOUNT', JSONData, ORDER_ID);
 
-    Result := TJSONObject.Create.AddPair('status', 'success');
-    TXDataOperationContext.Current.Handler.ManagedObjects.Add(Result);
+    // Updated so an object isn't being created in the exception for memory control
+    Result.AddPair('status', 'success');
   except
     on E: Exception do
     begin
-      Result := TJSONObject.Create.AddPair('error', E.Message);
+      Result.AddPair('error', E.Message);
     end;
   end;
 end;
 
+
 function TLookupService.AddStatusSchedule(StatusType: string; order: TJSONObject; ORDER_ID: integer): string;
 var
   SQL: string;

kgOrdersServer/Source/rOrders.pas

@@ -133,7 +133,7 @@ begin
       colorList := TJSONArray(colorObject.GetValue('items'));
       result := IntToStr(colorList.Count);
     finally
-      colorObject.Free; // Free TJSONObject to avoid leaks
+      colorObject.Free;
     end;
   end;
 end;
@@ -161,7 +161,7 @@ begin
     frxOrders.Export(frxPDFExport1);
     //frxOrders.ShowPreparedReport;
   finally
-    frxOrders.Clear; // Clear the report to avoid memory bloat
+     frxOrders.Clear; // Clears the report to avoid memory bloat
   end;
 
   Logger.Log(5, 'PDF saved to: ' + ReportFileName);

kgOrdersServer/Source/uLibrary.pas

@@ -7,7 +7,6 @@ uses
 
 procedure LoadDatabaseSettings( uc: TUniConnection; iniFilename: string );
 procedure DoQuery( uq: TUniQuery; sql: string );
-function CalculateAge( const dob, dt: TDateTime ): Integer;
 
 implementation
 
@@ -39,33 +38,5 @@ begin
   uq.Open;
 end;
 
-function CalculateAge( const dob, dt: TDateTime): Integer;
-var
-  age: Integer;
-  y1, m1, d1, y2, m2, d2: Word;
-begin
-  Result := 0;
-
-  if dt < dob then
-    Exit;
-
-  DecodeDate( dob, y1, m1, d1);
-  DecodeDate( dt, y2, m2, d2);
-  age := y2 - y1;
-  // Feb 29
-  //if ( (m1=2) and (d1=29) ) and ( not IsLeapYear(y2) ) then
-  //  d1 := 28;
-
-  if (m1 = 2) and (d1 = 29) and (not (IsLeapYear (y2))) then
-  begin
-    m1 := 3;
-    d1 := 1;
-  end;
-
-  if (m2 < m1) or ((m2 = m1) and (d2 < d1)) then
-    Dec(age);
-  Result := age
-end;
-
 
 end.

kgOrdersServer/kgOrdersServer.ini

 [Settings]
 MemoLogLevel=4
 FileLogLevel=5
-LogFileNum=71
+LogFileNum=90
 webClientVersion=1.0.0
 
 [Database]
-Server=192.168.159.132
---Server=192.168.102.130
+--Server=192.168.159.132
+Server=192.168.102.130
 --Server=192.168.75.133
 --Database=
 --Username=